[ESDB-159-3] Add support for checking Entitlements #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothycoleman
changed the title
timothycoleman
force-pushed
the
timothycoleman/check-entitlements
branch
2 times, most recently
from
862fc5b to
87fa591
Compare
Also do not expect to find a License in the DI. Putting the license in the DI involved doing some sync over async and also meant that the licence couldn't change later (say, if it expired). Instead we now find a ILicenseService in the DI which provides us with the current license and an observable of license updates. Also provides a method for the plugins to reject a license if it doesn't have sufficient entitlements
timothycoleman
force-pushed
the
timothycoleman/check-entitlements
branch
from
87fa591 to
e759f25
Compare
hayley-jean
approved these changes
Jul 25, 2024
| public bool HasEntitlements(string[] entitlements, [MaybeNullWhen(true)] out string missing) { | ||
| foreach (var entitlement in entitlements) { | ||
| if (!HasEntitlement(entitlement)) { | ||
| missing = entitlement; |
There was a problem hiding this comment.
This isn't necessary for the preview release since there is only one entitlement, but it might be more user-friendly to return all of the missing entitlements rather than just the first one
There was a problem hiding this comment.
yeah fair comment, lets consider that in the future especially if it turns out that some plugins have multiple required entitlements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also do not expect to find a License in the DI. Putting the license in the DI involved doing some sync over async and also meant that the licence couldn't change later (say, if it became in valid).
Instead we now find a ILicenseService in the DI which provides us with the current license and an observable of license updates. Also provides a method for the plugins to reject a license if it doesn't have sufficient entitlements